[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command |
Date: |
Thu, 05 Jul 2012 08:14:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/05/2012 06:51 AM, Orit Wasserman wrote:
> Change XBZRLE cache size in bytes (the size should be a power of 2).
> If XBZRLE cache size is too small there will be many cache miss.
>
> Signed-off-by: Benoit Hudzia <address@hidden>
> Signed-off-by: Petter Svard <address@hidden>
> Signed-off-by: Aidan Shribman <address@hidden>
> Signed-off-by: Orit Wasserman <address@hidden>
> ---
> + {
> + .name = "migrate_set_cachesize",
> + .args_type = "value:o",
> + .params = "value",
> + .help = "set cache size (in bytes) for XBZRLE migrations,"
> + "the cache size will be rounded down to the nearest "
> + "power of 2.\n"
> + "The cache size effects the number of cache misses."
> + "In case of a high cache miss ratio you need to increase
> the cache size",
Inconsistent indentation. Kill those TABs.
> +++ b/migration.c
> @@ -22,6 +22,7 @@
> #include "qemu_socket.h"
> #include "block-migration.h"
> #include "qmp-commands.h"
> +#include <math.h>
Urgh. You STILL haven't killed this bogus include, even though I've
been mentioning it since my v12 review. I'm really getting frustrated
with how long this series is being dragged out.
>
> //#define DEBUG_MIGRATION
>
> @@ -43,7 +44,7 @@ enum {
>
> #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */
>
> -/* Migration XBZRLE cache size */
> +/* Migration XBZRLE default cache size */
Again from my v12 review, this hunk should be squashed into the patch
that first introduces the comment.
> +migrate_set_cachesize
> +---------------------
> +
> +Set cache size to be used by XBZRLE migration, the cache size will be round
> down
> +to the nearset power of 2
Another v12 review leftover:
s/nearset/nearest/
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v15 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, (continued)
- [Qemu-devel] [PATCH v15 3/9] Add cache handling functions, Orit Wasserman, 2012/07/05
- [Qemu-devel] [PATCH v15 2/9] Add XBZRLE documentation, Orit Wasserman, 2012/07/05
- [Qemu-devel] [PATCH v15 7/9] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/07/05
- [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command, Orit Wasserman, 2012/07/05
- Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command,
Eric Blake <=
- [Qemu-devel] [PATCH v15 9/9] Add XBZRLE statistics, Orit Wasserman, 2012/07/05