Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

[Paolo Bonzini]

Il 05/07/2012 20:03, Blue Swirl ha scritto:
> > > > +            if (s->wwn) {
> > > > +                outbuf[buflen++] = 0x1; // Binary
> > > > +                outbuf[buflen++] = 0x3; // NAA
> > > > +                outbuf[buflen++] = 0;   // reserved
> > >
> > > C99 comments.
> >
> > Just following the style of this code.  Feel free to send a patch to
> > replace with #defines.
> 
> That's not how we should work. New code should be compliant with our
> goals. Pushing the responsibility for fixing issues to other people
> does not scale.

I believe the coding style are attacking the wrong problem.  It's
end-of-line comments that should be avoided in favor of #defines, packed
structs, designated initializers, etc.  But for end-of-line comments,
C++ comments are superior to /* */ comments.

I do plan to fix the clarity issue with SCSI data structures and
constants.  But for now, the best compromise is to keep C++ comments
IMHO.  I'm not pushing the responsibility to other people in general,
but if they think C++ comments are a major issue they can send patches.

Paolo