Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

[Kevin Wolf]

Am 05.07.2012 20:07, schrieb Blue Swirl:
> On Wed, Jul 4, 2012 at 8:34 AM, Kevin Wolf <address@hidden> wrote:
>> Am 03.07.2012 21:19, schrieb Blue Swirl:
>>> On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf <address@hidden> wrote:
>>>> Am 09.06.2012 14:12, schrieb Blue Swirl:
>>>>> Move logging functions from exec.c to qemu-log.c,
>>>>> compile it only once.
>>>>>
>>>>> Signed-off-by: Blue Swirl <address@hidden>
>>>>
>>>> This broke the TARGET_I386 specific logging options.
>>>
>>> Also DEBUG_IOPORT. Maybe  the logger should be compiled for each
>>> target, but that does not look attractive.
>>
>> The options that I see are more or less:
>>
>> 1. Compile the file for each target
>> 2. Move only cpu_log_items[] to a separately compiled file
>> 3. Replace the #ifdef by a runtime check
> 
> I think we could just remove #ifdeffery and adjust the text with
> "(x86)", for example
>  "show protected mode far calls/returns/exceptions (x86 only)"
> 
> It should be safe to enable all options, obviously some of them won't
> do anything if enabled for the wrong architecture.

Right, should be good enough indeed.

Kevin