[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and depos
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields |
Date: |
Sun, 8 Jul 2012 12:13:42 +0100 |
On 8 July 2012 11:59, Stefan Weil <address@hidden> wrote:
> Am 08.07.2012 12:01, schrieb Peter Maydell:
>> On 8 July 2012 10:55, Lluís Vilanova <address@hidden> wrote:
>>> Wouldn't it be better to use "unsigned int" instead on all the "start"
>>> and "length" arguments?
>>
>> See the arguments about this on one of the previous patch series:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg04304.html
> I just read that arguments and now agree with Blue and with
> Lluís that 'unsigned' would be better.
...whereas I still agree with Markus (and with the people who wrote
the Linux kernel bitops functions that we borrowed elsewhere in
bitops.h) that we should be using plain 'int'.
-- PMM