[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check |
Date: |
Mon, 9 Jul 2012 15:30:21 +0200 |
On 09.07.2012, at 15:29, Gerd Hoffmann wrote:
> On 07/09/12 14:06, Alexander Graf wrote:
>> When just calling ./configure on my box, I always ran into the same issue:
>>
>> In file included from /usr/include/nss3/pkcs11t.h:1780,
>> from /usr/include/nss3/keythi.h:41,
>> from /usr/include/nss3/keyt.h:41,
>> from /usr/include/nss3/pk11pub.h:43,
>> from libcacard/vcard_emul_nss.c:21:
>> /usr/include/nss3/pkcs11n.h:365:26: error: "__GNUC_MINOR" is not defined
>>
>> This is a bug in nss3. But why didn't configure bail out of the feature
>> if it doesn't even compile? Because this really is just a warning, not an
>> error. But configure builds its test program without -Werror, while we do
>> build our sources with -Werror by default.
>>
>> Force the check to also use -Werror. This fixes the default build for me
>> again.
>
> Good idea, but shouldn't we do that
> (a) for all compile tests and
> (b) only with --enable-werror
Yeah, my configure foo wasn't good enough to figure out when exactly -Werror is
passed in. At the point in time when the smartcard check is done, neither
$werror nor $QEMU_CFLAGS have been set.
Alex