|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface |
| Date: | Tue, 10 Jul 2012 11:29:46 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Il 09/07/2012 21:17, address@hidden ha scritto: > + > +/* Phyical interface types. */ > +#define IPMI_KCS 1 > +#define IPMI_BT 2 > +#define IPMI_SMIC 3 The code is not 100% consistent for values that are defined in hardware specs (enums are preferred for new code, but that's not really enforced). However, for everything else please use enums rather than arbitrary #defines. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |