[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types |
Date: |
Tue, 10 Jul 2012 20:37:24 +0100 |
On 10 July 2012 20:18, Blue Swirl <address@hidden> wrote:
> On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster <address@hidden> wrote:
>> There is no consensus. I recognize the power of maintainers to force a
>> change even without consensus. Use it wisely.
>
> I thought I refuted all concrete arguments except performance.
No, you made various claims that Markus and I at least
disagreed with. (Conversely, we have made various claims
that you disagree with -- this is what "no consensus" means...)
> However, Avi kindly provided this part.
One extra instruction, which isn't a load/store or branch? This is the
worst kind of premature microoptimisation. If we're changing this
it should be rooted in arguments about maintainability or similar,
or alternatively if it's really a performance improvement I'm
sure you can produce the benchmarks that demonstrate that :-)
[Plus the extract/deposit ops aren't doing array accesses!]
-- PMM
- [Qemu-devel] [PATCH v2 0/3] bitops patches, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH v2 1/3] bitops: fix types, blauwirbel, 2012/07/08
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Markus Armbruster, 2012/07/09
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Blue Swirl, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Blue Swirl, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Peter Maydell, 2012/07/10
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Blue Swirl, 2012/07/12
- Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Peter Maydell, 2012/07/12
Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types, Kevin Wolf, 2012/07/11
[Qemu-devel] [PATCH v2 3/3] bitops: use bool, blauwirbel, 2012/07/08