[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?: |
|
Date: |
Wed, 11 Jul 2012 14:54:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 08.07.2012 14:09, schrieb Andreas Schwab:
> address@hidden writes:
>
>> + pstrcpy(bs->backing_format, sizeof(bs->backing_format),
>> + backing_fmt ? backing_file : "");
>
> s/backing_file/backing_fmt/
Which is why such changes are probably a bad idea. Even more so if they
aren't scripted.
Does this patch improve anything? Last time I checked, qemu only
compiled on gcc anyway.
Kevin
- [Qemu-devel] [PATCH 0/5] portability patches, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH 2/5] Avoid returning void, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH 3/5] Use __asm__ instead of asm or __asm, blauwirbel, 2012/07/08
- [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, blauwirbel, 2012/07/08
- Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Blue Swirl, 2012/07/12
- Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Peter Maydell, 2012/07/12
- Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Blue Swirl, 2012/07/13
- Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Kevin Wolf, 2012/07/13
- Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Blue Swirl, 2012/07/13
Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:, Markus Armbruster, 2012/07/09