[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup |
Date: |
Wed, 11 Jul 2012 17:40:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 10.07.2012 11:12, schrieb Markus Armbruster:
> 29 patches may look discouraging, but most patches are small, and the
> ones that aren't just move code around.
>
> Goals of this series:
>
> 1. One more step towards a clean separation block device host and
> guest part.
>
> 2. Purge CHS geometry from the block layer
>
> Part I [PATCH 01/29]: Floppy geometry
>
> Part II [PATCH 02-03/29]: vvfat geometry bug fixes
>
> Part III [PATCH 04-10/29]: Clean up hard disk geometry guessing code
>
> Part IV [PATCH 11-12/29]: Clean up CMOS hard disk info setup
>
> Part V [PATCH 13-24/29]: qdev properties for disk geometry
>
> Part VI [PATCH 25-29/29]: A few more fixes and cleanups
>
> A few more cleanups are in the works, in particular geometry checking
> code duplication pointed out by Kevin.
>
> This patch series is also available at
> git://repo.or.cz/qemu/armbru.git
> tag geo-v3
>
> v3: Rebase; drop the three patches that have been committed already
> Fix uninitialized variable in PATCH 02/29 (Anthony)
>
> v2: New hw/block-common.h (Blue & Kevin)
> Coding style here & there (Blue)
> Tracepoint parameter types (Stefan)
>
> Markus Armbruster (29):
> fdc: Move floppy geometry guessing back from block.c
> vvfat: Fix partition table
> vvfat: Do not clobber the user's geometry
> qtest: Add hard disk geometry test
> hd-geometry: Move disk geometry guessing back from block.c
> hd-geometry: Add tracepoints
> hd-geometry: Unnest conditional in hd_geometry_guess()
> hd-geometry: Factor out guess_chs_for_size()
> hd-geometry: Clean up gratuitous goto in hd_geometry_guess()
> hd-geometry: Clean up confusing use of prior translation hint
> hd-geometry: Cut out block layer translation middleman
> ide pc: Cut out the block layer geometry middleman
> blockdev: Save geometry in DriveInfo
> qdev: Introduce block geometry properties
> hd-geometry: Switch to uint32_t to match BlockConf
> scsi-hd: qdev properties for disk geometry
> virtio-blk: qdev properties for disk geometry
> ide: qdev properties for disk geometry
> qtest: Cover qdev properties for disk geometry
> qdev: Collect private helpers in one place
> qdev: New property type chs-translation
> ide: qdev property for BIOS CHS translation
> qtest: Cover qdev property for BIOS CHS translation
> block: Geometry and translation hints are now useless, purge them
> ide pc: Put hard disk info into CMOS only for hard disks
> qtest: Test we don't put hard disk info into CMOS for a CD-ROM
> hd-geometry: Compute BIOS CHS translation in one place
> blockdev: Drop redundant CHS validation for if=ide
> Relax IDE CHS limits from 16383,16,63 to 65535,16,255
>
> block.c | 254 ------------------------------
> block.h | 39 +----
> block/vvfat.c | 57 ++++---
> block_int.h | 1 -
> blockdev.c | 24 +--
> blockdev.h | 2 +
> hw/Makefile.objs | 2 +-
> hw/block-common.h | 29 ++++
> hw/fdc.c | 122 +++++++++++++--
> hw/fdc.h | 10 +-
> hw/hd-geometry.c | 157 ++++++++++++++++++
> hw/ide.h | 4 +-
> hw/ide/core.c | 30 +++-
> hw/ide/internal.h | 7 +-
> hw/ide/qdev.c | 46 +++++-
> hw/pc.c | 78 ++++------
> hw/qdev-properties.c | 160 ++++++++++---------
> hw/qdev.h | 3 +
> hw/s390-virtio-bus.c | 1 +
> hw/scsi-disk.c | 70 ++++++---
> hw/virtio-blk.c | 42 ++++-
> hw/virtio-pci.c | 1 +
> tests/Makefile | 2 +
> tests/hd-geo-test.c | 428
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> trace-events | 4 +
> vl.c | 2 +-
> 26 files changed, 1067 insertions(+), 508 deletions(-)
> create mode 100644 hw/block-common.h
> create mode 100644 hw/hd-geometry.c
> create mode 100644 tests/hd-geo-test.c
>
Thanks, applied all to the block branch.
Kevin
- [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c, (continued)
- [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 23/29] qtest: Cover qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 24/29] block: Geometry and translation hints are now useless, purge them, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 22/29] ide: qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 28/29] blockdev: Drop redundant CHS validation for if=ide, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 26/29] qtest: Test we don't put hard disk info into CMOS for a CD-ROM, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 25/29] ide pc: Put hard disk info into CMOS only for hard disks, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 20/29] qdev: Collect private helpers in one place, Markus Armbruster, 2012/07/10
- Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup,
Kevin Wolf <=