Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

[Vasilis Liaskovitis]

Hi,

On Wed, Jul 11, 2012 at 08:59:03AM -0600, Eric Blake wrote:
> On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote:
> > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method.
> > This patch implements a tail queue to store guest notifications for memory
> > hot-add and hot-remove requests.
> > 
> > Guest responses for memory hotplug command on a per-dimm basis can be 
> > detected
> > with the new hmp command "info memhp" or the new qmp command "query-memhp"
> > Examples:
> >     
> 
> > +++ b/qapi-schema.json
> > @@ -1862,3 +1862,29 @@
> >  # Since: 0.14.0
> >  ##
> >  { 'command': 'netdev_del', 'data': {'id': 'str'} }
> > +
> > +##
> > +# @MemHpInfo:
> > +#
> > +# Information about status of a memory hotplug command
> > +#
> > +# @Dimm: the Dimm associated with the result
> > +#
> > +# @result: the result of the hotplug command
> > +#
> > +# Since: 1.1.3
> 
> Should probably be 1.2, not 1.1.3.
>

right

> > +#
> > +##
> > +{ 'type': 'MemHpInfo',
> > +  'data': {'Dimm': 'str', 'request': 'str', 'result': 'str'} }
> 
> Why the upper case?  Wouldn't 'dimm' be more consistent?
>

I will change to "dimm"

> > +
> > +##
> > +# @query-memhp:
> 
> Why are we abbreviating?  It might be better to name the QMP command
> query-memory-hotplug
> 

agreed, memhp is a bit cryptic. I will change to your suggestion 

> > +#
> > +# Returns a list of information about pending hotplug commands
> > +#
> > +# Returns: a list of @MemhpInfo
> > +#
> > +# Since: 1.1.3
> 
> Likewise for 1.2.

right

> 
> > +
> > +- "Dimm": Dimm name (json-str)
> > +- "request": type of hot request: hot-add or hot-remove  (json-str)
> > +- "result": result of the hotplug request for this Dimm success or failure 
> > (json-str)
> 
> This may need tweaks (such as s/Dimm/dimm/) based on resolution of above
> comments.
ok, it will be "dimm"

thanks,

- Vasilis