[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm |
Date: |
Thu, 12 Jul 2012 11:59:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
> hmp-commands.hx | 2 +-
> hmp.c | 10 ++++++++++
> hmp.h | 1 +
> qapi-schema.json | 17 +++++++++++++++++
> qmp-commands.hx | 24 ++++++++++++++++++++++++
> savevm.c | 21 +++++++++++----------
> sysemu.h | 1 -
> 7 files changed, 64 insertions(+), 12 deletions(-)
> +
> +##
> +# @delvm:
This name is worse than 'loadvm' or 'savevm', in that we are NOT
deleting the entire vm, but a named snapshot stored within the vm.
Would naming it 'delete-vm-snapshot' make more sense (in which case the
others might make more sense as 'save-vm-snapshot' and 'load-vm-snapshot')?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots, Pavel Hrdina, 2012/07/12
[Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm, Pavel Hrdina, 2012/07/12