qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translati


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translation
Date: Fri, 13 Jul 2012 09:09:20 +0100

On 13 July 2012 05:35, Jia Liu <address@hidden> wrote:
> +static inline uint32_t field(uint32_t val, int start, int length)
> +{
> +    val >>= start;
> +    val &= ~(~0 << length);
> +    return val;
> +}

extract32() is in bitops.h now, so it would be better to
use that instead. Thanks for prodding us to actually write
this utility routine :-)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]