Re: [Qemu-devel] [PATCH v9 07/15] target-or32: Add instruction translation

[Jia Liu]

Hi Peter,

On Fri, Jul 13, 2012 at 4:09 PM, Peter Maydell <address@hidden> wrote:
> On 13 July 2012 05:35, Jia Liu <address@hidden> wrote:
>> +static inline uint32_t field(uint32_t val, int start, int length)
>> +{
>> +    val >>= start;
>> +    val &= ~(~0 << length);
>> +    return val;
>> +}
>
> extract32() is in bitops.h now, so it would be better to
> use that instead. Thanks for prodding us to actually write
> this utility routine :-)

I've replace field extract32 after I receive your mail in one minute :-)

Thank you for mind me.

>
> -- PMM

Regards,
Jia