Re: [Qemu-devel] [QEMU RFC PATCH 5/7] pc: write lapic info (apic IDs) to fw_cfg so seabios can use it

[Eduardo Habkost]

On Thu, Jul 12, 2012 at 07:29:02PM +0000, Blue Swirl wrote:
[...]
> CODING_STYLE requires CamelCase, also below.
> 
[...]
> > +    struct lapic_info_table *lapic_table = g_malloc0(lapic_info_size);;
> 
> ;--
> 
> > +    lapic_table->count = max_cpus;
> > +    for (i = 0; i < max_cpus; i++) {
> > +        lapic_table->entries[i].apic_id = apic_id_for_cpu(i);
> > +    }
> > +    fw_cfg_add_bytes(fw_cfg, FW_CFG_LAPIC_INFO, (uint8_t *)lapic_table,
> 
> You are passing a structure with host endianness. Please convert the
> fields with cpu_to_le32().

Thanks. I will fix the issues if I send a new version of this patch. But
I believe we'll find a way to make FW_CFG_LAPIC_INFO unnecessary.

-- 
Eduardo