[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when setting
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when setting |
Date: |
Mon, 16 Jul 2012 08:24:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 15/07/2012 22:25, address@hidden ha scritto:
> From: Corey Minyard <address@hidden>
>
> When setting an object, if you don't release the previous object
> that was there, it may become unusable. This change allows a
> chardev to be removed from one object's properties and added to
> another's.
> ---
> qom/object.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index 00bb3b0..484dc77 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -731,6 +731,8 @@ void object_property_set(Object *obj, Visitor *v, const
> char *name,
> if (!prop->set) {
> error_set(errp, QERR_PERMISSION_DENIED);
> } else {
> + if (prop->release)
> + prop->release(obj, name, prop->opaque);
> prop->set(obj, v, prop->opaque, name, errp);
> }
> }
>
Acked-by: Paolo Bonzini <address@hidden>
... but you need to run scripts/checkpatch.pl on your patches to conform
to coding style.
Thanks!
Paolo
- [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry, minyard, 2012/07/15
- [Qemu-devel] [PATCH 10/16] qom: release previous object when setting, minyard, 2012/07/15
- Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when setting,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 07/16] qemu-char: remove free of chr from win_stdio_close, minyard, 2012/07/15
- [Qemu-devel] [PATCH 15/16] IPMI: Add a local BMC simulation, minyard, 2012/07/15
- [Qemu-devel] [PATCH 02/16] pc: move SMBIOS setup to after device init, minyard, 2012/07/15
- [Qemu-devel] [PATCH 03/16] vl: Move init_timer_alarm() earlier, minyard, 2012/07/15
- [Qemu-devel] [PATCH 14/16] IPMI: Add a BT low-level interface, minyard, 2012/07/15
- [Qemu-devel] [PATCH 16/16] IPMI: Add an external connection simulation interface, minyard, 2012/07/15
- [Qemu-devel] [PATCH 05/16] qemu-char: Allow a chardev to reconnect if disconnected, minyard, 2012/07/15
- [Qemu-devel] [PATCH 06/16] qemu-char: Fix a race reporting opens and closes, minyard, 2012/07/15
- [Qemu-devel] [PATCH 04/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts, minyard, 2012/07/15