Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

[Stefan Weil]

Am 16.07.2012 17:39, schrieb Eric Blake:
> On 07/15/2012 01:54 PM, Stefan Weil wrote:
> > Am 15.07.2012 22:26, schrieb Mike Frysinger:
> > > We should not quote the PKG_CONFIG setting as this deviates from the
> > > canonical upstream behavior that gets integrated with all other build
> > > systems, and deviates from how we treat all other toolchain variables
> > > that we get from the environment.
> > >
> > > Ultimately, the point is that it breaks passing custom flags directly
> > > to pkg-config via the env var where this normally works elsewhere,
> > > and it used to work in the past.
> >
> >
> > What about passing custom flags with QEMU_PKG_CONFIG_FLAGS?
> >
> > Removing the quotes will not allow paths containing spaces,
> > so that's not a good idea.
>
> Actually, it IS a good idea.  The de facto standard build environment
> requires that pkg-config is not allowed to live in a path containing
> spaces, precisely so that you can override the variable to pass options
> to your preferred location of pkg-config; and if your build setup is
> truly so messed up as to have pkg-config installed in a canonical
> location with spaces, then you can also tweak your unusual environment
> to provide a symlink to pkg-config that does not contain spaces as the
> workaround.

That sounds reasonable. Then the following patch was at least partially
unnecessary:

commit 17884d7b6462b0fe497f08fec6091ffbe04caa8d
Author: Sergei Trofimovich <address@hidden>
Date:   Tue Jan 31 22:03:45 2012 +0300

    ./configure: request pkg-config to provide private libs when static 
linking

    Added wrapper around pkg-config to allow:
    - safe options injection via ${QEMU_PKG_CONFIG_FLAGS}
    - spaces in path to pkg-config

    Signed-off-by: Sergei Trofimovich <address@hidden>
    CC: Peter Maydell <address@hidden>
    Signed-off-by: Anthony Liguori <address@hidden>

With Mike's new patch, QEMU_PKG_CONFIG_FLAGS is no longer needed
because options can be passed using the pkg-config macro.
I suggest to remove it.

Regards,

Stefan W.