Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

[Stefan Weil]

Am 17.07.2012 20:43, schrieb Peter Maydell:
> On 15 July 2012 19:34, Stefan Weil <address@hidden> wrote:
> > "+=" does not work with dash and other simple /bin/sh implementations.
> >
> > The new code prepends the flag while the old code either did not work
> > (it continued after an error message which typically was not read) or
> > appended the flag. That difference should not matter here.
> >
> > Signed-off-by: Stefan Weil <address@hidden>
> > ---
> >   configure |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 12351f5..0269ba0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2822,7 +2822,7 @@ int main(int argc, char **argv)
> >   }
> >   EOF
> >     if ! compile_prog "" "" ; then
> > -    CFLAGS+="-march=i486"
> > +    CFLAGS="-march=i486 $CFLAGS"
> >     fi
> >   fi
>
> This is not quite the right fix for this. This flag should be in
> QEMU_CFLAGS, because it is a flag without which QEMU
> would be unable to compile. See previous discussion in this
> thread:
>
> http://lists.xen.org/archives/html/xen-devel/2012-04/msg00330.html
>
> (Unfortunately Olaf never submitted an updated patch.)
>
> -- PMM

If the user overrides CFLAGS, I expect that he/she will notice
that compilation fails and hopefully find the cause (only
expert users should override CFLAGS). Overriding -march=i486
might be useful to set -march=i686.

Therefore it was not so obvious to me whether CFLAGS or
QEMU_CFLAGS was the better choice.

I don't mind if we decide to use QEMU_CFLAGS here,
but suggest putting that change in a separate patch.

This one fixes a shell syntax error without changing the macro name.

Regards,

Stefan W.