[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory. |
Date: |
Thu, 19 Jul 2012 14:50:11 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/19/2012 02:41 PM, Anthony PERARD wrote:
> On 17/07/12 19:36, Stefano Stabellini wrote:
>> On Tue, 17 Jul 2012, Avi Kivity wrote:
>>> How about pushing the call into cpu_physical_memory_set_dirty_flags()?
>>> Would that reduce the number of call sites?
>>
>> Pushing the calls to cpu_physical_memory_set_dirty_flags and
>> cpu_physical_memory_set_dirty_range would make the code much nicer.
>> However being these functions in exec-obsolete.h, are they at risk of
>> removal?
>
> I thought about it, but when I saw that set_dirty were called only when
> it was not already set as dirty where the call seams to be necessary.
>
> I just try to call xen_modified_mem only within
> cpu_phy_mem_set_dirty_flags but it does not work, even when I tried to
> clear the dirtybits. But I maybe don't do the right thing yet to clear
> the dirty bits
You can wrap the if (not dirty) make_it_dirty() sequence in a helper,
and insert your hypercall in the helper, unconditionally.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 0/4] Xen, introducing dirty log for migration., Anthony PERARD, 2012/07/17
- [Qemu-devel] [PATCH 2/4] xen: Introduce xen_modified_memory., Anthony PERARD, 2012/07/17
- [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Anthony PERARD, 2012/07/17
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Avi Kivity, 2012/07/17
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Anthony PERARD, 2012/07/17
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Avi Kivity, 2012/07/17
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Stefano Stabellini, 2012/07/17
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Avi Kivity, 2012/07/18
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Anthony PERARD, 2012/07/19
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory.,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Anthony PERARD, 2012/07/19
Re: [Qemu-devel] [PATCH 3/4] exec, memory: Call to xen_modified_memory., Stefano Stabellini, 2012/07/17
[Qemu-devel] [PATCH 1/4] QMP, Introduce set-global-dirty-log command., Anthony PERARD, 2012/07/17