[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard sh
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code |
Date: |
Fri, 20 Jul 2012 14:28:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0 |
Am 17.07.2012 21:19, schrieb Peter Maydell:
> On 17 July 2012 20:07, Stefan Weil <address@hidden> wrote:
>> If the user overrides CFLAGS, I expect that he/she will notice
>> that compilation fails and hopefully find the cause (only
>> expert users should override CFLAGS). Overriding -march=i486
>> might be useful to set -march=i686.
>>
>> Therefore it was not so obvious to me whether CFLAGS or
>> QEMU_CFLAGS was the better choice.
>
> Yes, I had to dig to find out the underlying principle
> distinguishing the two. Having found it I would like us to
> fix this in a way which respects that principle.
I was planning to pick up Olaf's patch doing just that but haven't got
around to it in time for v1.1. Olaf, do you have time to resubmit a
patch to upstream qemu-devel as requested by Peter and me?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg