[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support |
Date: |
Fri, 20 Jul 2012 08:47:16 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >> + /* FIXME: probably not the best idea to have this on the stack ... */
> >> + u32 script[] = {
> >
> > Several places in the code DMA to the stack already (usb-ehci,
> > usb-uhci, ata).
>
> My concern isn't DMA'ing to the stack, but the size of the script and
> possible stack overruns. But maybe it is a moot point with the stack
> switching added to seabios recently.
Disk access code will have at least a 4K stack in 32bit mode and a 2K
stack in 16bit mode.
-Kevin