[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] powerpc pci: fixed packing of ranges[]
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 1/6] powerpc pci: fixed packing of ranges[] |
Date: |
Sat, 21 Jul 2012 13:27:00 +0100 |
From: Alexey Kardashevskiy <address@hidden>
By default mingw-gcc is trying to pack structures the way to
preserve binary compatibility with MS Visual C what leads to
incorrect and unexpected padding in the PCI bus ranges property of
the sPAPR PHB.
The patch replaces __attribute__((packed)) with more strict QEMU_PACKED
which actually is __attribute__((gcc_struct, packed)) on Windows.
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Tested-by: Stefan Weil <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Acked-by: Alexander Graf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/spapr_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index 47ba5ff..b2e4f78 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -418,7 +418,7 @@ int spapr_populate_pci_devices(sPAPRPHBState *phb,
uint64_t child;
uint64_t parent;
uint64_t size;
- } __attribute__((packed)) ranges[] = {
+ } QEMU_PACKED ranges[] = {
{
cpu_to_be32(b_ss(1)), cpu_to_be64(0),
cpu_to_be64(phb->io_win_addr),
--
1.7.10.4
- [Qemu-devel] [PULL 0/6] Trivial patches for 14 to 21 July 2012, Stefan Hajnoczi, 2012/07/21
- [Qemu-devel] [PATCH 2/6] Recognize PCID feature, Stefan Hajnoczi, 2012/07/21
- [Qemu-devel] [PATCH 5/6] qdev: Fix Open Firmware comment, Stefan Hajnoczi, 2012/07/21
- [Qemu-devel] [PATCH 3/6] Use macro QEMU_PACKED for new packed structures, Stefan Hajnoczi, 2012/07/21
- [Qemu-devel] [PATCH 1/6] powerpc pci: fixed packing of ranges[],
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 6/6] Fix some more Qemus in documentation and help text, Stefan Hajnoczi, 2012/07/21
- [Qemu-devel] [PATCH 4/6] cpus.c: Make all_cpu_threads_idle() static, Stefan Hajnoczi, 2012/07/21