[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub |
Date: |
Tue, 24 Jul 2012 11:49:21 +0100 |
On Mon, Jul 23, 2012 at 9:07 PM, Laszlo Ersek <address@hidden> wrote:
> On 07/20/12 14:01, Stefan Hajnoczi wrote:
>
>> @@ -638,11 +642,17 @@ static void get_vlan(Object *obj, Visitor *v, void
>> *opaque,
>> {
>> DeviceState *dev = DEVICE(obj);
>> Property *prop = opaque;
>> - VLANState **ptr = qdev_get_prop_ptr(dev, prop);
>> - int64_t id;
>> + VLANClientState **ptr = qdev_get_prop_ptr(dev, prop);
>> + int64_t id = -1;
>>
>> - id = *ptr ? (*ptr)->id : -1;
>> - visit_type_int64(v, &id, name, errp);
>> + if (*ptr) {
>> + unsigned int hub_id;
>> + if (!net_hub_id_for_client(*ptr, &hub_id)) {
>> + id = (int64_t)hub_id;
>> + }
>> + }
>> +
>> + visit_type_int(v, &id, name, errp);
>> }
>
> Should we use uint32 here? (No particular reason, just for "cleanliness"
> or whatever.)
As part of the int64_t -> uint32_t type cleanup we can change this. I
think it's a safe change to make since no reasonable command-line
would make use of the silent 32-bit truncation.
Stefan
- [Qemu-devel] [PATCH 00/16] net: Move legacy QEMU VLAN code into net/hub.c, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 08/16] net: Remove VLANState, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 14/16] net: cleanup deliver/deliver_iov func pointers, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 07/16] net: Remove vlan code from net.c, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 11/16] net: Rename vc local variables to nc, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 02/16] net: Use hubs for the vlan feature, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 09/16] net: Rename non_vlan_clients to net_clients, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 13/16] net: Make "info network" output more readable info, Stefan Hajnoczi, 2012/07/20