Re: [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file ancestors count

[Kevin Wolf]

Am 25.07.2012 10:11, schrieb address@hidden:
> From: Benoît Canet <address@hidden>
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  hmp.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hmp.c b/hmp.c
> index 6b72a64..19dcb65 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon)
>              if (info->value->inserted->has_backing_file) {
>                  monitor_printf(mon, " backing_file=");
>                  monitor_print_filename(mon, 
> info->value->inserted->backing_file);
> +                monitor_printf(mon, " backing_file_ancestors_count=%" PRId64,
> +                    info->value->inserted->backing_file_ancestors_count);

This is not what a user interface looks like. Maybe something like "%d
backing files", and omit the message if there aren't any backing files.

Kevin