qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inje


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq
Date: Wed, 25 Jul 2012 18:28:42 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-07-25 18:24, Peter Maydell wrote:
> On 25 July 2012 17:18, Peter Maydell <address@hidden> wrote:
>> Not in the sense of "you need to KVM_CREATE_IRQCHIP it",
> 
> ...incidentally I was thinking about maybe moving kvm_irqchip_create()
> from being called by kvm_init() to being called by the device
> init function for the relevant irqchip (particularly we'll need
> to do that if we adopt Avi's suggestion of having a parameter
> to KVM_CREATE_IRQCHIP to specify a particular kind of irqchip).
> But that's more invasive surgery so I didn't want to do it yet.

This won't fly as irchip affects the whole orchestra (vcpus & irqchip
stubs in user space), at least on x86, and has to be called in the
current order. That's also why kernel_irqchip is a machine options, not
an option of one of the many device models.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux





reply via email to

[Prev in Thread] Current Thread [Next in Thread]