Re: [Qemu-devel] [PATCH V3 2/3] block: Use bdrv_get_backing_file_ancestors_count()

[Benoît Canet]

Le Wednesday 25 Jul 2012 à 10:39:11 (-0600), Eric Blake a écrit :
> On 07/25/2012 06:36 AM, address@hidden wrote:
> 
> > +++ b/qapi-schema.json
> > @@ -398,6 +398,8 @@
> >  #
> >  # @backing_file: #optional the name of the backing file (for copy-on-write)
> >  #
> > +# @backing_file_ancestors_count: #the count of ancestors backing files 
> > (since: 1.2)
> > +#
> >  # @encrypted: true if the backing device is encrypted
> >  #
> >  # @bps: total throughput limit in bytes per second is specified
> > @@ -418,9 +420,10 @@
> >  ##
> >  { 'type': 'BlockDeviceInfo',
> >    'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str',
> > -            '*backing_file': 'str', 'encrypted': 'bool',
> > -            'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int',
> > -            'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} }
> > +            '*backing_file': 'str', 'backing_file_ancestors_count': 'int',
> 
> I hit send too soon.  QMP prefers '-' over '_', so the new parameter
> should be 'backing-file-ancestors-count' (or with my proposal,
> 'backing-file-depth').  Yes, this particular struct has some _ for
> historical reasons, but that doesn't mean that new elements must share
> the misery.

I'll change it too.

Benoît
> 
> -- 
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>