Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped

[Peter Maydell]

On 25 July 2012 17:54, Luiz Capitulino <address@hidden> wrote:

(Subject should be "to be", not "be".)

> A future commit will add a new qapi script which escapes that character.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  scripts/qapi.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index e062336..9aa518f 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -21,7 +21,9 @@ def tokenize(data):
>          elif data[0] == "'":
>              data = data[1:]
>              string = ''
> -            while data[0] != "'":
> +            while True:
> +                if data[0] == "'" and string[len(string)-1] != "\\":
> +                    break
>                  string += data[0]
>                  data = data[1:]
>              data = data[1:]

Won't this cause us to look at string[-1] if
the input data has two ' characters in a row?
(also, maybe infinite loop if the input string has an
unterminated ' ?)

-- PMM