Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

[Andreas Färber]

Am 25.07.2012 08:55, schrieb Christian Borntraeger:
> On 24/07/12 21:35, Blue Swirl wrote:
> [...]
>> Braces
> [...]
>> Braces, also below two times.
> 
> a generic question. We did it that way because the other code in vl.c is like 
> that.
> 
> So we should make new code follow the CodingStyle even if the surrounding 
> code looks
> different, but we dont touch that surrounding code. right?

There has been resistance towards doing touch-all Coding Style cleanups
since it is invasive and messes with git-blame.

Our policy is to have new code comply with the current Coding Style
(with some exceptions in audio code) and to apply fixes (e.g., add
braces) on the lines touched or in the same hunk.
scripts/checkpatch.pl complains otherwise.

Depending on amount and invasiveness of such cleanups it has sometimes
been requested (e.g., for code movements that show up as deletes and
adds) that larger cleanups be split out into a preceding patch, to keep
things reviewable and to avoid checkpatch.pl errors.

HTE,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg