[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] qapi: add query-machines command
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] qapi: add query-machines command |
Date: |
Fri, 27 Jul 2012 13:12:45 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Eric Blake <address@hidden> writes:
> On 07/27/2012 07:37 AM, Anthony Liguori wrote:
>> This provides the same output as -M ? but in a structured way.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>> qapi-schema.json | 28 ++++++++++++++++++++++++++++
>> qmp-commands.hx | 6 ++++++
>> vl.c | 31 +++++++++++++++++++++++++++++++
>> 3 files changed, 65 insertions(+), 0 deletions(-)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 28e9914..5b47026 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -2200,3 +2200,31 @@
>> # Since: 0.14.0
>> ##
>> { 'command': 'closefd', 'data': {'fdname': 'str'} }
>> +
>> +##
>> +# @MachineInfo:
>> +#
>> +# Information describing a machine.
>> +#
>> +# @name: the name of the machine
>> +#
>> +# @alias: #optional an alias for the machine name
>
> Can a machine have more than one alias?
No, it can't. Really, alias is only used to map 'pc' -> 'pc-1.1'. It's
never more complicated than that.
Regards,
Anthony Liguori
> In that case, it might be better to have:
>
> @name: the name of the machine
> @alias-of: #optional if present, name is an alias, and this lists the
> canonical form that it resolves to
>
> --
> Eric Blake address@hidden +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
[Qemu-devel] [PATCH 3/7] qapi: add query-machines command, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command, Anthony Liguori, 2012/07/27