[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field(
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field() |
Date: |
Fri, 27 Jul 2012 18:31:53 -0300 |
Use the 'device' passed by the user and call qmp_query_block() to
get the 'filename' info.
error_get_field() is going to be dropped by a future commit.
Signed-off-by: Luiz Capitulino <address@hidden>
---
hmp.c | 37 ++++++++++++++++++++++++++++---------
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git a/hmp.c b/hmp.c
index a906f8a..435c9cd 100644
--- a/hmp.c
+++ b/hmp.c
@@ -783,17 +783,35 @@ static void hmp_change_read_arg(Monitor *mon, const char
*password,
static void cb_hmp_change_bdrv_pwd(Monitor *mon, const char *password,
void *opaque)
{
- Error *encryption_err = opaque;
+ char *device = opaque;
Error *err = NULL;
- const char *device;
-
- device = error_get_field(encryption_err, "device");
qmp_block_passwd(device, password, &err);
hmp_handle_error(mon, &err);
- error_free(encryption_err);
monitor_read_command(mon, 1);
+ g_free(device);
+}
+
+static char *get_device_file(const char *device)
+{
+ BlockInfoList *bdev_list, *bdev;
+ char *ret;
+
+ bdev_list = qmp_query_block(NULL);
+ for (bdev = bdev_list; bdev; bdev = bdev->next) {
+ if (!strcmp(bdev->value->device, device)) {
+ break;
+ }
+ }
+
+ assert(bdev);
+ assert(bdev->value->has_inserted);
+
+ ret = g_strdup(bdev->value->inserted->file);
+ qapi_free_BlockInfoList(bdev_list);
+
+ return ret;
}
void hmp_change(Monitor *mon, const QDict *qdict)
@@ -814,9 +832,9 @@ void hmp_change(Monitor *mon, const QDict *qdict)
qmp_change(device, target, !!arg, arg, &err);
if (error_is_type(err, QERR_DEVICE_ENCRYPTED)) {
- monitor_printf(mon, "%s (%s) is encrypted.\n",
- error_get_field(err, "device"),
- error_get_field(err, "filename"));
+ char *filename = get_device_file(device);
+ monitor_printf(mon, "%s (%s) is encrypted.\n", device, filename);
+ g_free(filename);
if (!monitor_get_rs(mon)) {
monitor_printf(mon,
"terminal does not support password prompting\n");
@@ -824,9 +842,10 @@ void hmp_change(Monitor *mon, const QDict *qdict)
return;
}
readline_start(monitor_get_rs(mon), "Password: ", 1,
- cb_hmp_change_bdrv_pwd, err);
+ cb_hmp_change_bdrv_pwd, (void *) g_strdup(device));
return;
}
+
hmp_handle_error(mon, &err);
}
--
1.7.11.2.249.g31c7954.dirty
- [Qemu-devel] [PATCH 02/27] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg, (continued)
- [Qemu-devel] [PATCH 02/27] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 03/27] qerror: QERR_DEVICE_ENCRYPTED: add filename info to human msg, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 04/27] qerror: reduce public exposure, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 05/27] qerror: drop qerror_abort(), Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 06/27] qerror: QError: drop file, linenr, func, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 07/27] qerror: qerror_format(): return an allocated string, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 08/27] qerror: don't delay error message construction, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 09/27] error: don't delay error message construction, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 10/27] qmp: query-block: add 'valid_encryption_key' field, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 11/27] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 13/27] error: error_is_type(): don't use error_get_field(), Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 15/27] block: block_int: include qerror.h, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 16/27] hmp: hmp.h: include qdict.h, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 17/27] qapi: qapi-types.h: don't include qapi/qapi-types-core.h, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 19/27] qapi: don't convert enum strings to lowercase, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 20/27] qapi-schema: add ErrorClass enum, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 21/27] qerror: qerror_table: don't use C99 struct initializers, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 18/27] qapi: generate correct enum names for camel case enums, Luiz Capitulino, 2012/07/27
- [Qemu-devel] [PATCH 23/27] qerror: use ErrorClass for QERR_ macro, Luiz Capitulino, 2012/07/27