[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges |
|
Date: |
Mon, 30 Jul 2012 01:08:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 29.07.2012 14:22, schrieb Michael S. Tsirkin:
> On Thu, Jul 26, 2012 at 02:28:32PM +0200, Andreas Färber wrote:
>> Uglify the parent field to enforce QOM-style access via casts.
>> Don't just typedef PCIHostState, either use it directly or embed it.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> I already said I don't see the point of this change. [...]
You did, and still Anthony instructed me otherwise. Please discuss that
with him, thanks.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v4 07/18] ppc4xx_pci: QOM'ify ppc4xx PCI host bridge, (continued)
- [Qemu-devel] [PATCH v4 07/18] ppc4xx_pci: QOM'ify ppc4xx PCI host bridge, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH v4 11/18] unin_pci: QOM'ify UniNorth PCI host bridges, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH v4 13/18] pci: Derive PCI host bridges from TYPE_PCI_HOST_BRIDGE, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH v4 12/18] pci_host: Turn into SysBus-derived QOM type, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH RFC v4 15/18] MAINTAINERS: Document sPAPR (pSeries) machine, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH RFC v4 17/18] MAINTAINERS: Document Bamboo machine, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH RFC v4 16/18] MAINTAINERS: Document e500 machine, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges, Andreas Färber, 2012/07/26
- [Qemu-devel] [PATCH RFC v4 18/18] MAINTAINERS: Document virtex_ml507 machine, Andreas Färber, 2012/07/26