qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 37/47] add hierarchical bitmap data type and tes


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 37/47] add hierarchical bitmap data type and test cases
Date: Mon, 30 Jul 2012 16:18:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

Il 30/07/2012 15:39, Paolo Bonzini ha scritto:
>>> +HBitmap *hbitmap_alloc(uint64_t size, int granularity)
>>> >> +{
>>> >> +    HBitmap *hb = g_malloc0(sizeof(struct HBitmap));
>>> >> +    int i;
>>> >> +
>>> >> +    assert(granularity >= 0 && granularity < 64);
>> > 
>> > Shouldn't this be granularity < BITS_PER_LONG?
> Yep, thanks.
> 

Actually, no.  granularity is always applied to int64_t/uint64_t values.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]