[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migra
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters |
Date: |
Mon, 30 Jul 2012 14:37:02 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Juan Quintela <address@hidden> writes:
> Orit Wasserman <address@hidden> wrote:
>> The management can enable/disable a capability for the next migration by
>> using
>> migrate_set_parameter command.
>> The management can query the current migration capabilities using
>> query-migrate-parameters
>>
>> Signed-off-by: Orit Wasserman <address@hidden>
>> Signed-off-by: Juan Quintela <address@hidden>
>
> I just noticed .... shouldn't we use
>
> migrate_set_parameter cache_size 256M
> ???
>
> I think that even the old migration parameters could be added to this
> one?
>
> migrate_set_parameter downtime 30ms
> migrate_set_parameter bandwidth 1G
>
> This way everything would be more regular, and easier on libvirt, as new
> parameters would be trivial to ask for?
>
> Notice that I can understand that we have to maintain the old commands
> for compability, but we can do "regularly" for new ones?
I think this is worse. How does libvirt determine which parameters are
valid?
Let's do migrate_set_cache_size. Please don't introduce commands that
multiplex multiple behavior. They do more harm than good.
Regards,
Anthony Liguori
>
> Later, Juan.
- [Qemu-devel] [PATCH 01/11] Add migration capabilities, (continued)
[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 04/11] Add cache handling functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/07/29
[Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/07/29