Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

[Kevin Wolf]

Am 30.07.2012 17:05, schrieb Paolo Bonzini:
> Il 30/07/2012 16:47, Kevin Wolf ha scritto:
>>>> +BlockJobInfo *block_job_query(BlockJob *job)
>>>> +{
>>>> +    BlockJobInfo *info = g_new(BlockJobInfo, 1);
>>>> +    info->type   = g_strdup(job->job_type->job_type);
>>>> +    info->device = g_strdup(bdrv_get_device_name(job->bs));
>>>> +    info->len    = job->len;
>>>> +    info->offset = job->offset;
>>>> +    info->speed  = job->speed;
>>>> +    return info;
>>>> +}
>> Why did you convert the initialisation to separate statement? If you
>> really want to do this, I think using g_new0 would be safer now, but I
>> actually like compound literals better.
> 
> Later on I will have some more initialization beyond the list of fields,
> so I preferred an explicit list.  I can change it back if you prefer.

What I'm really interested in is having zero-initialisation for any not
explicitly initialised fields, just to be on the safe side. You can do
that with g_new0() or with compound literals, that's a matter of taste.
My taste happens to prefer the latter, but I won't criticise a patch
based on taste as long as it's doing the same thing functionally.

Kevin