Re: [Qemu-devel] [RFC PATCH 4/4] qmp: Introduce memchar_read QMP command

[Eric Blake]

On 08/01/2012 03:48 AM, Lei Li wrote:
> Signed-off-by: Lei Li <address@hidden>
> ---
>  qapi-schema.json |   20 ++++++++++++++++++++
>  qemu-char.c      |   16 ++++++++++++++++
>  qmp-commands.hx  |   28 ++++++++++++++++++++++++++++
>  3 files changed, 64 insertions(+), 0 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3c8530f..23edda9 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -226,6 +226,26 @@
>    'data': {'chardev': 'str', 'size': 'int', 'data': 'str'} }
>  
>  ##
> +# @memchar_read:

As in the previous patch, s/_/-/g

> +#
> +# Provide read interface for memchardev. Read from memchar
> +# char device and return the data.
> +#
> +# @chardev: the name of the  memchar char device.
> +#
> +# @size: the size to write in bytes.

s/write/read/

> +#
> +# Returns: The data read from memchar as string.
> +#          If @chardev is not a valid memchar device, DeviceNotFound
> +#          If an I/O error occurs while reading, IOError
> +#
> +# Since: 1.2
> +##
> +{ 'command': 'memchar_read',
> +  'data': {'chardev': 'str', 'size': 'int'},
> +  'returns': 'str' }

Again, is there going to be a binary encoding issue?

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature