[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 34/34] error, qerror: drop QDict member
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 34/34] error, qerror: drop QDict member |
Date: |
Wed, 1 Aug 2012 22:02:54 -0300 |
Used to store error information, but it's unused now.
Signed-off-by: Luiz Capitulino <address@hidden>
---
error.c | 4 ----
qerror.c | 4 ----
qerror.h | 1 -
3 files changed, 9 deletions(-)
diff --git a/error.c b/error.c
index 5c6c90f..b07ffa0 100644
--- a/error.c
+++ b/error.c
@@ -19,7 +19,6 @@
struct Error
{
- QDict *obj;
char *msg;
ErrorClass err_class;
};
@@ -53,8 +52,6 @@ Error *error_copy(const Error *err)
err_new = g_malloc0(sizeof(*err));
err_new->msg = g_strdup(err->msg);
err_new->err_class = err->err_class;
- err_new->obj = err->obj;
- QINCREF(err_new->obj);
return err_new;
}
@@ -77,7 +74,6 @@ ErrorClass error_get_class(const Error *err)
void error_free(Error *err)
{
if (err) {
- QDECREF(err->obj);
g_free(err->msg);
g_free(err);
}
diff --git a/qerror.c b/qerror.c
index e1606d3..6d924fb 100644
--- a/qerror.c
+++ b/qerror.c
@@ -102,7 +102,6 @@ void qerror_report(ErrorClass eclass, const char *fmt, ...)
/* Evil... */
struct Error
{
- QDict *obj;
char *msg;
ErrorClass err_class;
};
@@ -113,8 +112,6 @@ void qerror_report_err(Error *err)
qerr = qerror_new();
loc_save(&qerr->loc);
- QINCREF(err->obj);
- qerr->error = err->obj;
qerr->err_msg = g_strdup(err->msg);
qerr->err_class = err->err_class;
@@ -156,7 +153,6 @@ static void qerror_destroy_obj(QObject *obj)
assert(obj != NULL);
qerr = qobject_to_qerror(obj);
- QDECREF(qerr->error);
g_free(qerr->err_msg);
g_free(qerr);
}
diff --git a/qerror.h b/qerror.h
index 2299e00..3f17c52 100644
--- a/qerror.h
+++ b/qerror.h
@@ -21,7 +21,6 @@
typedef struct QError {
QObject_HEAD;
- QDict *error;
Location loc;
char *err_msg;
ErrorClass err_class;
--
1.7.11.2.249.g31c7954.dirty
- [Qemu-devel] [PATCH 30/34] qemu-ga: switch to the new error format on the wire, (continued)
- [Qemu-devel] [PATCH 32/34] qerror: drop qerror_table and qerror_format(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 28/34] error: add error_get_class(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 25/34] qerror: qerror_table: don't use C99 struct initializers, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 34/34] error, qerror: drop QDict member,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 26/34] error, qerror: add ErrorClass argument to error functions, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 33/34] error: drop error_get_qobject()/error_set_qobject(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 24/34] qapi-schema: add ErrorClass enum, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 31/34] error, qerror: pass desc string to error calls, Luiz Capitulino, 2012/08/01
- Re: [Qemu-devel] [PATCH v1 00/34]: add new error format, Luiz Capitulino, 2012/08/02
- Re: [Qemu-devel] [PATCH v1 00/34]: add new error format, Markus Armbruster, 2012/08/02