[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1 |
|
Date: |
Thu, 02 Aug 2012 11:00:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 02/08/2012 10:32, Wenchao Xia ha scritto:
>>
>> ssize_t qb_read(struct QBlockState *qbs, void *buf, size_t len, off_t
>> offset)
>>
> OK.
>
>>> +{
>>> + int ret;
>>> + BlockDriverState *bs;
>>> +
>>> + bs = (BlockDriverState *)qbs->bdrvs;
>>> +
>>> + ret = bdrv_read(bs, start / 512,
>>> + buf, len / 512);
>>
>> IIRC there is a constant for 512 somewhere.
>>
> will include that header.
Also assert that start and len are aligned.
Paolo
- Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1, (continued)
Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1, Wenchao Xia, 2012/08/02
Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1, Blue Swirl, 2012/08/01