Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

[Benoît Canet]

Le Thursday 02 Aug 2012 à 08:04:46 (-0600), Eric Blake a écrit :
> On 08/02/2012 04:16 AM, Benoît Canet wrote:
> > Signed-off-by: Benoit Canet <address@hidden>
> > ---
> >  block/qorum.c |   15 +++++++++++++++
> 
> s/qorum/quorum/ for the file name.
ack

> 
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 block/qorum.c
> > 
> > diff --git a/block/qorum.c b/block/qorum.c
> > new file mode 100644
> > index 0000000..3341021
> > --- /dev/null
> > +++ b/block/qorum.c
> > @@ -0,0 +1,15 @@
> > +/*
> 
> > + */
> > +
> > 
> 
> What good is a patch that adds a file whose sole contents are a comment?
>  This should not be an independent patch; please squash it into the
> first commit that really adds contents to the file.
ack

> 
> -- 
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>