Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h

[Luiz Capitulino]

On Fri,  3 Aug 2012 11:51:02 +0100
Stefan Hajnoczi <address@hidden> wrote:

> From: Amos Kong <address@hidden>
> 
> Signed-off-by: Amos Kong <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  qemu_socket.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qemu_socket.h b/qemu_socket.h
> index 4689ff3..1a2f517 100644
> --- a/qemu_socket.h
> +++ b/qemu_socket.h
> @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia);
>  #endif /* !_WIN32 */
>  
>  #include "qemu-option.h"
> -#include "error.h"
>  #include "qerror.h"

nack on this one, as it's dropping the wrong file.

qemu_socket.h declares functions that take an Error argument, so it has
to include error.h.

However, qerror.h should be dropped and any build breakage should be
fixed by including qerror.h in the .c files it's missing.

>  
>  /* misc helpers */