Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling

[Paolo Bonzini]

Il 06/08/2012 14:48, Stefan Hajnoczi ha scritto:
>> >         Interesting, I tested vhost (or thought so).  Can you try this
>> >         patch instead?
> Does this really make the code better than just reverting the patch?

The main problem here is that the current code has calls to
event_notifier_get_fd.  These compile under Windows, but they will not
make sense when EventNotifier is ported to Windows because it will not
have a file descriptor.  So I want to remove event_notifier_get_fd from
public code, and reverting the patch is a step backwards.

> I don't like this name because virtio-blk-data-plane also wants to use
> the ioeventfd.  I suggest we call it use_handler (note logic is
> reversed from with_vhost).

Ok, noted.

Paolo