Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional

[Andreas Färber]

Am 07.08.2012 15:03, schrieb Pavel Hrdina:
> Signed-off-by: Pavel Hrdina <address@hidden>

This is in need of a more detailed commit message: What exactly is this
fixing? Or is this a preparation for a particular new command?

Andreas

> ---
>  monitor.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index bbf30e6..2b3583c 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor 
> *mon,
>                      val = 1;
>                  } else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
>                      val = 0;
> +                } else if (*typestr == '?') {
> +                    typestr++;
> +                    break;
>                  } else {
>                      monitor_printf(mon, "Expected 'on' or 'off'\n");
>                      goto fail;
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg