[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor dis
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect |
Date: |
Tue, 7 Aug 2012 18:32:07 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 03, 2012 at 01:28:06PM -0400, Corey Bryant wrote:
> Each fd set has a boolean that keeps track of whether or not the
> fd set is in use by a monitor connection. When a monitor
> disconnects, all fds that are members of an fd set with refcount
> of zero are closed. This prevents any fd leakage associated with
> a client disconnect prior to using a passed fd.
>
> v5:
> -This patch is new in v5.
> -This support addresses concerns from v4 regarding fd leakage
> if the client disconnects unexpectedly. (address@hidden,
> address@hidden, address@hidden)
>
> v6:
> -No changes
>
> Signed-off-by: Corey Bryant <address@hidden>
> ---
> monitor.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
The lifecycle of fdsets and fds isn't clear to me. It seems like just a
refcount in fdset should handle this without extra fields like in_use.
Stefan
- [Qemu-devel] [PATCH v6 0/6] file descriptor passing using fd sets, Corey Bryant, 2012/08/03
- [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect, Corey Bryant, 2012/08/03
- Re: [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v6 5/6] block: Convert close calls to qemu_close, Corey Bryant, 2012/08/03
- [Qemu-devel] [PATCH v6 6/6] block: Enable qemu_open/close to work with fd sets, Corey Bryant, 2012/08/03
- [Qemu-devel] [PATCH v6 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg, Corey Bryant, 2012/08/03
- [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets, Corey Bryant, 2012/08/03
- Re: [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets, Stefan Hajnoczi, 2012/08/07
- Re: [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets, Corey Bryant, 2012/08/07
- Re: [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets, Stefan Hajnoczi, 2012/08/08
- Re: [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets, Corey Bryant, 2012/08/08