[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 09/15] isolate qdev-independent parts of qdev_prop_set
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 09/15] isolate qdev-independent parts of qdev_prop_set_globals() |
Date: |
Tue, 7 Aug 2012 16:56:47 -0300 |
Create a qdev-independent function, and use a callback that calls
qdev_prop_parse().
Signed-off-by: Eduardo Habkost <address@hidden>
---
global-properties.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/global-properties.c b/global-properties.c
index a1c3581..d99bcee 100644
--- a/global-properties.c
+++ b/global-properties.c
@@ -17,9 +17,20 @@ void qdev_prop_register_global_list(GlobalProperty *props)
}
}
-void qdev_prop_set_globals(DeviceState *dev)
+static void qdev_global_parse(Object *obj, const char *property,
+ const char *value, Error **errp)
+{
+ DeviceState *dev = DEVICE(obj);
+ qdev_prop_parse(dev, property, value, errp);
+}
+
+static void object_set_globals(Object *obj,
+ void (*parse_fn)(Object *obj,
+ const char *property,
+ const char *value,
+ Error **errp))
{
- ObjectClass *class = object_get_class(OBJECT(dev));
+ ObjectClass *class = object_get_class(obj);
do {
GlobalProperty *prop;
@@ -28,7 +39,7 @@ void qdev_prop_set_globals(DeviceState *dev)
if (strcmp(object_class_get_name(class), prop->driver) != 0) {
continue;
}
- qdev_prop_parse(dev, prop->property, prop->value, &err);
+ parse_fn(obj, prop->property, prop->value, &err);
if (err) {
qerror_report_err(err);
exit(1);
@@ -38,6 +49,11 @@ void qdev_prop_set_globals(DeviceState *dev)
} while (class);
}
+void qdev_prop_set_globals(DeviceState *dev)
+{
+ return object_set_globals(OBJECT(dev), qdev_global_parse);
+}
+
static int qdev_add_one_global(QemuOpts *opts, void *opaque)
{
GlobalProperty *g;
--
1.7.11.2
- [Qemu-devel] [RFC 00/15] attempt to fix CPU topology info on CPU APIC IDs, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 05/15] remove FW_CFG_MAX_CPUS from fw_cfg_init(), Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 03/15] kvm: set vcpu_id to APIC ID instead of CPU index, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 09/15] isolate qdev-independent parts of qdev_prop_set_globals(),
Eduardo Habkost <=
- [Qemu-devel] [RFC 10/15] create object_prop_set_globals(), Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 11/15] rename qdev_prop_register_global_list to qemu_globals_register_list, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 12/15] create qemu_global_get() function, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 08/15] move global properties code to global-properties.c, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 04/15] i386: create apic_id_for_cpu() function (v2), Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 06/15] pc: set FW_CFG data based on APIC ID calculation, Eduardo Habkost, 2012/08/07
- [Qemu-devel] [RFC 01/15] cpus.h: include cpu-common.h, Eduardo Habkost, 2012/08/07