[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snap
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy |
Date: |
Wed, 08 Aug 2012 12:27:33 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/08/2012 09:25 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan <address@hidden>
>
> PhysMap contain the flatview and radix-tree view, they are snapshot
> of system topology and should be consistent. With PhysMap, we can
> swap the pointer when updating and achieve the atomic.
>
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
> exec.c | 8 --------
> memory.c | 33 ---------------------------------
> memory.h | 62
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 3 files changed, 60 insertions(+), 43 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 0e29ef9..01b91b0 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -156,8 +156,6 @@ typedef struct PageDesc {
> #endif
>
> /* Size of the L2 (and L3, etc) page tables. */
> -#define L2_BITS 10
> -#define L2_SIZE (1 << L2_BITS)
>
> #define P_L2_LEVELS \
> (((TARGET_PHYS_ADDR_SPACE_BITS - TARGET_PAGE_BITS - 1) / L2_BITS) + 1)
> @@ -185,7 +183,6 @@ uintptr_t qemu_host_page_mask;
> static void *l1_map[V_L1_SIZE];
>
> #if !defined(CONFIG_USER_ONLY)
> -typedef struct PhysPageEntry PhysPageEntry;
This (and the other stuff you're moving) is private memory internals.
It should be moved to memory-internals.h (currently named exec-obsolete.h).
--
error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree, (continued)
[Qemu-devel] [PATCH 12/15] qdev: using devtree lock to protect device's accessing, Liu Ping Fan, 2012/08/08
[Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view, Liu Ping Fan, 2012/08/08
[Qemu-devel] [PATCH 14/15] qom: object_unref call reclaimer, Liu Ping Fan, 2012/08/08
[Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy, Liu Ping Fan, 2012/08/08