Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

[Cornelia Huck]

On Wed, 8 Aug 2012 19:03:14 +0000
Blue Swirl <address@hidden> wrote:


> >> > +struct vq_info_block {
> >> > +    uint64_t queue;
> >> > +    uint16_t num;
> >> > +} QEMU_PACKED;
> >> > +
> >> > +struct vq_config_block {
> >> > +    uint16_t index;
> >> > +    uint16_t num;
> >> > +} QEMU_PACKED;
> >>
> >> Aren't these KVM structures? They should be defined in a KVM header
> >> file file in linux-headers.
> >
> > Not really, virtio-ccw isn't tied to kvm.
> >
> > I see this more as command blocks that are specific to the "control
> > unit" - like something that would be defined in an attachment
> > specification for a classic s390 device (and in the virtio spec in this
> > case) and modeled as C structures here.
> 
> OK. Then please use CamelCase for these too.
> 

OK.