[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabet
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order |
Date: |
Thu, 9 Aug 2012 17:38:17 -0300 |
On Thu, 09 Aug 2012 13:29:32 -0600
Eric Blake <address@hidden> wrote:
> On 08/09/2012 11:28 AM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > QMP/qmp-events.txt | 266
> > ++++++++++++++++++++++++++---------------------------
> > 1 file changed, 130 insertions(+), 136 deletions(-)
>
> Code motion that deletes 6 more lines than it adds? I'm assuming those
> were blank lines, and that spacing is more consistent now, but it's
> nicer to see a code motion patch with matching diffstat.
Yes, blank lines. I'll avoid doing this in the future.
>
> Reviewed-by: Eric Blake <address@hidden>
>
> >
> > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> > index b8afedb..e37a04e 100644
> > --- a/QMP/qmp-events.txt
> > +++ b/QMP/qmp-events.txt
>
> Nits to possibly address in a followup patch (do NOT fix them at the
> same time as code motion, though):
>
> >
> > +SPICE_CONNECTED, SPICE_DISCONNECTED
> > +-----------------------------------
> > +
> > +Emitted when a SPICE client connects or disconnects.
>
> Should this be broken into two listings?
>
> > +SPICE_INITIALIZED
> > +-----------------
> > +
> > +Emitted after initial handshake and authentication takes place (if any)
> > +and the SPICE channel is up'n'running
>
> Do we like this cutesy abbreviation, or should we spell out 'and'?
>
> > +
> > +Data:
> > +
> > +- "server": Server information (json-object)
> > + - "host": IP address (json-string)
> > + - "port": port number (json-string)
> > + - "family": address family (json-string, "ipv4" or "ipv6")
> > + - "auth": authentication method (json-string, optional)
> > +- "client": Client information (json-object)
> > + - "host": IP address (json-string)
> > + - "port": port number (json-string)
> > + - "family": address family (json-string, "ipv4" or "ipv6")
> > + - "connection-id": spice connection id. All channels with the same id
> > + belong to the same spice session (json-int)
> > + - "channel-type": channel type. "1" is the main control channel, filter
> > for
> > + this one if you want track spice sessions only
> > (json-int)
> > + - "channel-id": channel id. Usually "0", might be different needed when
> > + multiple channels of the same type exist, such as
> > multiple
> > + display channels in a multihead setup (json-int)
> > + - "tls": whevener the channel is encrypted (json-bool)
>
> s/whevener/whether/
>
- [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 1/4] qmp: don't emit the RESET event on wakeup from S3, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 4/4] qmp: qmp-events.txt: add missing doc for the SUSPEND event, Luiz Capitulino, 2012/08/09
- Re: [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes, Gerd Hoffmann, 2012/08/10