[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest i
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run |
Date: |
Thu, 9 Aug 2012 17:40:21 -0300 |
On Thu, 09 Aug 2012 11:57:38 -0600
Eric Blake <address@hidden> wrote:
> On 08/09/2012 11:28 AM, Luiz Capitulino wrote:
> > Today, the WAKEUP event is emitted when a wakeup _request_ is made.
> > This could be the system_wakeup command, for example.
> >
> > A better semantic would be to emit the event when the guest is
> > already running, as that's what matters in the end. This commit does
> > that change.
> >
> > In theory, this could break compatibility. In practice, it shouldn't
> > happen though, as clients shouldn't rely on timing characteristics of
> > the events. That is, a client relying that the guest is not running
> > when the event arrives may break if the event arrives after the guest
> > is already running.
>
> Yeah, no problem with that semantic change from libvirt.
>
>
> > +WAKEUP
> > +------
> > +
> > +Emitted when the guest has been waken up from S3 and is running.
>
> grammar:
>
> s/has been waken/has woken/
Fixed in v2. If I don't respin I'll merge the fixed version in the
qmp branch (I won't respin just because of this).
>
> or maybe
>
> s/has been waken up/has been awakened/
>
- [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 1/4] qmp: don't emit the RESET event on wakeup from S3, Luiz Capitulino, 2012/08/09
- [Qemu-devel] [PATCH 4/4] qmp: qmp-events.txt: add missing doc for the SUSPEND event, Luiz Capitulino, 2012/08/09
- Re: [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes, Gerd Hoffmann, 2012/08/10