[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unpl
|
From: |
liu ping fan |
|
Subject: |
Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug |
|
Date: |
Fri, 10 Aug 2012 14:43:25 +0800 |
On Thu, Aug 9, 2012 at 3:40 PM, Paolo Bonzini <address@hidden> wrote:
> Il 09/08/2012 09:28, liu ping fan ha scritto:
>>>> >> +static void
>>>> >> +pci_e1000_unmap(PCIDevice *p)
>>>> >> +{
>>>> >> + /* DO NOT FREE anything!until refcnt=0 */
>>>> >> + /* isolate from memory view */
>>>> >> +}
>>> >
>>> > At least you need to call the superclass method.
>>> >
>> Refer to 0013-hotplug-introduce-qdev_unplug_complete-to-remove-dev.patch,
>> we have the following sequence
>> qdev_unmap->pci_unmap_device->pci_e1000_unmap. So pci_e1000_unmap
>> need not to do anything.
>
> But then this patch is unnecessary, isn't it?
>
Yes, should remove from next version
Regards,
pingfan
> Paolo
>
- [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views, (continued)
[Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug, Liu Ping Fan, 2012/08/08
[Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree, Liu Ping Fan, 2012/08/08
Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree, Avi Kivity, 2012/08/08
[Qemu-devel] [PATCH 12/15] qdev: using devtree lock to protect device's accessing, Liu Ping Fan, 2012/08/08
[Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view, Liu Ping Fan, 2012/08/08