Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

[Peter Maydell]

On 10 August 2012 09:48, Andreas Färber <address@hidden> wrote:
> Am 09.08.2012 22:36, schrieb Peter Maydell:
>> Maciej submitted some other MIPS patches at about the same time:
>> http://patchwork.ozlabs.org/project/qemu-devel/list/?submitter=4977
>> at least some of which got reviewed by Richard Henderson and are
>> therefore good candidates to get committed, if you can fish them out
>> of the list and ping them...
>
> Actually there were better patches for the same bug by Meador, including
> git-style rather than SVN patches and adding a helper to initialize it
> consistently at all call sites.
>
> There's also DSP, Octeon, mips64 and signal handling patches around that
> someone needs to volunteer to update, test, clean up and queue.
> That a patch is on the list doesn't imply that it "just" needs to be
> applied though. So please be careful which patches you ping.

Yes, hence my suggestion to look for patches which got reviewed.

(Although speaking as somebody who has in the past submitted patches
which got neither reviewed nor rejected, I have some sympathy for the
idea that if nobody among us cares enough to look at a patch at all the
default should be to apply it.)

-- PMM