Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

[Andreas Färber]

Am 10.08.2012 11:00, schrieb Peter Maydell:
> On 10 August 2012 09:48, Andreas Färber <address@hidden> wrote:
>> Actually there were better patches for the same bug by Meador, including
>> git-style rather than SVN patches and adding a helper to initialize it
>> consistently at all call sites.
>>
>> There's also DSP, Octeon, mips64 and signal handling patches around that
>> someone needs to volunteer to update, test, clean up and queue.
>> That a patch is on the list doesn't imply that it "just" needs to be
>> applied though. So please be careful which patches you ping.
> 
> Yes, hence my suggestion to look for patches which got reviewed.
> 
> (Although speaking as somebody who has in the past submitted patches
> which got neither reviewed nor rejected, I have some sympathy for the
> idea that if nobody among us cares enough to look at a patch at all the
> default should be to apply it.)

>From my memory Maciej himself retracted his patches in reaction to a
reply from his colleague Meador. That might not show up when looking at
just one unthreaded reply-less patch, so in general ack but needs to
look at context, too.

Doing follow-ups based on this one or, in worst case, reverting is
certainly possible but the decision-making would best be done by someone
who actually uses mips - not that there's no users, just no volunteer
for a staging tree yet.

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg