[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] scsi: fix warning
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] scsi: fix warning |
Date: |
Fri, 10 Aug 2012 15:51:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 10/08/2012 15:26, Gerd Hoffmann ha scritto:
> hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this
> function
>
> Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5)
> are not clever enougth to figure, so sprinkle in a default: line to make
> them happy.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/scsi-bus.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index b8a857d..4981a02 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -761,6 +761,7 @@ static int ata_passthrough_12_xfer_size(SCSIDevice *dev,
> uint8_t *buf)
> switch (length) {
> case 0:
> case 3: /* USB-specific. */
> + default:
> xfer = 0;
> break;
> case 1:
> @@ -784,6 +785,7 @@ static int ata_passthrough_16_xfer_size(SCSIDevice *dev,
> uint8_t *buf)
> switch (length) {
> case 0:
> case 3: /* USB-specific. */
> + default:
> xfer = 0;
> break;
> case 1:
>
Acked-by: Paolo Bonzini <address@hidden>
Paolo